Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stamp): radius styles of color input #1862

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

designtesbrot
Copy link
Contributor

Description

The bootstrap color input styles do not play nicely with a large border-radius on color inputs (generate a large off-set backdrop). As styling of color inputs requires usage of vendor prefixes (which likely break in the future), this change makes the input transparent and adds a styled container, including JS code that makes the container reflect the selected code. Styles are idempotent (should not have impact on future color inputs) and scripts are regional (only on the stamp page). Demo:

Bildschirmaufnahme.2024-09-09.um.19.08.15.mov

Closes 1830

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Sep 9, 2024
@Frooodle Frooodle merged commit 0ad8c63 into Stirling-Tools:main Sep 9, 2024
2 checks passed
@Frooodle
Copy link
Member

Frooodle commented Sep 9, 2024

Nice change!

@Vamsi1810
Copy link
Contributor

This looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End Issues or pull requests related to front-end development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants