Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: introduces the verification of the python installation #1730

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Aug 21, 2024

Description

Now it is obvious whether Python is installed or not.

The user gets a better answer.

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner August 21, 2024 08:10
@github-actions github-actions bot added Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Translation API API-related issues or pull requests labels Aug 21, 2024
@Frooodle
Copy link
Member

I wonder if instead we should do
#820

@Frooodle
Copy link
Member

Frooodle commented Aug 21, 2024

Ahh i take it back you basically done this but have it show error rather than disable UI,
My only thought is should we run this only once at startup and store as var instead of running per command, not much to be gained checking each run

And then we can also add flag to "auto-disable-features-not-installed" or something if they want to just disable them completely (prob default to false?)

@Frooodle
Copy link
Member

Frooodle commented Aug 21, 2024

This could actually be a part of ProcessExecutor since it already is singleton, run check on first command run and then never again.. (or however you want to do it.. all works)

@Ludy87
Copy link
Contributor Author

Ludy87 commented Aug 21, 2024

I hope I understood it correctly :D

@Frooodle
Copy link
Member

Yeah looks good to me :)
Might turn it into a multi singleton down the line to support other dependencies but yeah good to merge !

@Frooodle Frooodle merged commit 1a594b2 into Stirling-Tools:main Aug 21, 2024
5 checks passed
@Ludy87 Ludy87 deleted the change_endpoint branch August 21, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related issues or pull requests Front End Issues or pull requests related to front-end development Java Pull requests that update Java code Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants