-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pt_BR ignored translations; Improved pt_BR translation #1705
Updated pt_BR ignored translations; Improved pt_BR translation #1705
Conversation
Hi, @Frooodle. I forgot to congratulate you and the Stirling-PDF community for such a great piece of software. Thank you! |
hi @guinuxbr! Thank you for your help in improving it. in your messages_pt_BR.properties parts of the translations are missing such as: invalidPasswordMessage, disabledCurrentUserMessage etc. |
Oh, I'm sorry to hear that. I was unaware that the blank lines are essential. I guess my IDE formatted it when I saved it. I'll double-check and re-add the blank lines. I'll also check the strings you mentioned. I thought I had translated all of them. Should I fix and create a new PR? |
The PR is clear, so it should not be a problem to just change it. |
I fixed the blank lines issue. |
I think you need to pull latest main branch |
I've tried again. It should be correct now 🙂. |
Description
Checklist:
Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)