Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pt_BR ignored translations; Improved pt_BR translation #1705

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Updated pt_BR ignored translations; Improved pt_BR translation #1705

merged 3 commits into from
Aug 20, 2024

Conversation

guinuxbr
Copy link
Contributor

Description

  • Updated pt_BR ignored translations
  • Improved pt_BR translation

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@guinuxbr guinuxbr requested a review from Frooodle as a code owner August 17, 2024 12:39
@github-actions github-actions bot added Documentation Improvements or additions to documentation Translation labels Aug 17, 2024
@guinuxbr
Copy link
Contributor Author

Hi, @Frooodle.

I forgot to congratulate you and the Stirling-PDF community for such a great piece of software.

Thank you!

@Ludy87
Copy link
Contributor

Ludy87 commented Aug 19, 2024

hi @guinuxbr!

Thank you for your help in improving it.

in your messages_pt_BR.properties parts of the translations are missing such as: invalidPasswordMessage, disabledCurrentUserMessage etc.
There are also several empty lines missing that must be strictly adhered to in order to pass a consistency analysis.

@guinuxbr
Copy link
Contributor Author

Oh, I'm sorry to hear that.

I was unaware that the blank lines are essential. I guess my IDE formatted it when I saved it. I'll double-check and re-add the blank lines.

I'll also check the strings you mentioned. I thought I had translated all of them.

Should I fix and create a new PR?

@Ludy87
Copy link
Contributor

Ludy87 commented Aug 19, 2024

The PR is clear, so it should not be a problem to just change it.

@guinuxbr
Copy link
Contributor Author

I fixed the blank lines issue.
Regarding the strings "invalidPasswordMessage" and "disabledCurrentUserMessage", I was unable to find both within any "messages_xx_XX.properties". Please let me know if something else needs to be fixed.

@Frooodle
Copy link
Member

I fixed the blank lines issue. Regarding the strings "invalidPasswordMessage" and "disabledCurrentUserMessage", I was unable to find both within any "messages_xx_XX.properties". Please let me know if something else needs to be fixed.

disabledCurrentUserMessage=The current user cannot be disabled

I think you need to pull latest main branch

@guinuxbr
Copy link
Contributor Author

I've tried again. It should be correct now 🙂.

@Frooodle Frooodle merged commit 3bd18f7 into Stirling-Tools:main Aug 20, 2024
5 checks passed
@guinuxbr guinuxbr deleted the feature/add_more_pt-BR_translations branch August 26, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants