Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further bug fixes when using context path #1475

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Jun 15, 2024

Description

further bug fixes when using context path

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner June 15, 2024 17:49
@Frooodle
Copy link
Member

Frooodle commented Jun 15, 2024

Is this needed?
Not seen any issues for this

@Ludy87
Copy link
Contributor Author

Ludy87 commented Jun 15, 2024

before:

image

after:

image

I think it is also future-proof. If you do not agree, you can also reject the PR.

@Frooodle
Copy link
Member

Seems valid :)
Just would want client to build path as much as possible Vs server building path

But I think it makes sense to be safe here

@Frooodle
Copy link
Member

Will quickly test how it plays with nginx before merge

@Frooodle
Copy link
Member

yeah all seems good! thanks as always

@Frooodle Frooodle merged commit f43fe15 into Stirling-Tools:main Jun 15, 2024
3 checks passed
@Ludy87 Ludy87 deleted the fix_contex_path branch August 19, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants