Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: method write and read settings.yml #1441 #1463

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Jun 15, 2024

Description

Please provide a summary of the changes, including relevant motivation and context.

Closes #1441

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner June 15, 2024 07:10
@Frooodle
Copy link
Member

Is this a breaking change for old settings files?

@Ludy87
Copy link
Contributor Author

Ludy87 commented Jun 15, 2024

Is this a breaking change for old settings files?

The process is:

  1. the "old" settings.yml is read in
  2. the template is read in
  3. the settings in the settings.yml are compared with the template, if there are differences, the value is left in the settings.yml
  4. if a new key is added to the template, it is also added to the settings.yml
  5. if a key has been removed from the template, it is removed from the settings.yml

@Frooodle
Copy link
Member

Awesome stuff!

@Frooodle Frooodle enabled auto-merge (squash) June 15, 2024 07:47
@Frooodle Frooodle disabled auto-merge June 15, 2024 07:47
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@Frooodle Frooodle merged commit fe9c5a7 into Stirling-Tools:main Jun 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different reading and writing procedure for settings.yml
2 participants