Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set when have many acls to speedup checks #154

Merged
merged 2 commits into from
May 3, 2023
Merged

Use set when have many acls to speedup checks #154

merged 2 commits into from
May 3, 2023

Conversation

ryarnyah
Copy link
Collaborator

@ryarnyah ryarnyah commented May 3, 2023 •
edited
Loading

Proposed Changes

  • Speedup ACLs check when having more thant 1000 ACLs (ex for 11632 it took ~550s with master & ~40s with this branch)

@ryarnyah ryarnyah requested a review from StephenSorriaux May 3, 2023 12:50
@ryarnyah ryarnyah merged commit 652fd0d into master May 3, 2023
@ryarnyah ryarnyah deleted the fix/acls-speed branch May 3, 2023 13:04
ryarnyah added a commit that referenced this pull request Oct 2, 2023
@ryarnyah
Use set when have many acls to speedup checks (#154)
a66a2a9 
* Use set when have many acls to speedup checks

* Downgrade ansible-compat test lib see ansible/molecule#3903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenSorriaux StephenSorriaux Awaiting requested review from StephenSorriaux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryarnyah