Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the value of the v1 property correctly when calling TransactionBuilder.from_xdr. #333

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

overcat
Copy link
Member

@overcat overcat commented Jun 14, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #333 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   98.98%   98.99%           
=======================================
  Files         115      115           
  Lines        5334     5349   +15     
=======================================
+ Hits         5280     5295   +15     
  Misses         54       54           
Flag Coverage Δ
#unittests 98.99% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
stellar_sdk/transaction_builder.py 100.00% <ø> (ø)
tests/test_transaction_builder.py 100.00% <100.00%> (ø)

@overcat overcat merged commit 0ce0321 into master Jun 14, 2020
@overcat overcat deleted the patch-v2.5 branch June 18, 2020 15:08
overcat added a commit that referenced this pull request Oct 12, 2020
* fix: set the value of the `v1` property correctly when calling TransactionBuilder.from_xdr. (#333)

* release: 2.5.3

* release: 2.6.0

* pre-release: 2.6.1-alpha1

* release: 2.6.1

* release: 2.6.2

* release: 2.6.3

* release: 2.6.4

* release: 2.7.0

* pre-release: 2.8.0-beta1

* release: 2.8.0

* adds an example of how to merge two accounts

Co-authored-by: Jun Luo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant