Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for CAP-0027 (MuxedAccounts) #300

Merged
merged 2 commits into from
Apr 19, 2020
Merged

feat: Add support for CAP-0027 (MuxedAccounts) #300

merged 2 commits into from
Apr 19, 2020

Conversation

overcat
Copy link
Member

@overcat overcat commented Apr 19, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Apr 19, 2020 •
edited
Loading

Codecov Report

Merging #300 into dev will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #300   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         113      113           
  Lines        4971     4973    +2     
=======================================
+ Hits         4923     4925    +2     
  Misses         48       48
Flag Coverage Δ
#unittests 99.03% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
stellar_sdk/transaction.py 100.00% <ø> (ø)
stellar_sdk/fee_bump_transaction.py 100.00% <100.00%> (ø)
stellar_sdk/keypair.py 100.00% <100.00%> (ø)
stellar_sdk/operation/account_merge.py 100.00% <100.00%> (ø)
stellar_sdk/operation/operation.py 100.00% <100.00%> (ø)
...ellar_sdk/operation/path_payment_strict_receive.py 100.00% <100.00%> (ø)
stellar_sdk/operation/path_payment_strict_send.py 100.00% <100.00%> (ø)
stellar_sdk/operation/payment.py 100.00% <100.00%> (ø)

@overcat overcat changed the title WIP: feat: Add support for CAP-0027 (MuxedAccounts) feat: Add support for CAP-0027 (MuxedAccounts) Apr 19, 2020
@overcat overcat merged commit 09ce949 into dev Apr 19, 2020
@overcat overcat mentioned this pull request Apr 19, 2020
Merged
abuiles
abuiles reviewed Apr 27, 2020
View reviewed changes
stellar_sdk/operation/account_merge.py
@@ -29,7 +29,7 @@ def type_code(cls) -> int:
return Xdr.const.ACCOUNT_MERGE

def _to_operation_body(self) -> Xdr.nullclass:
destination = Keypair.from_public_key(self.destination).xdr_account_id()
destination = Keypair.from_public_key(self.destination).xdr_muxed_account()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overcat could you extend this to support M accounts as destination too? see stellar/js-stellar-base@4009c3a

Copy link
Member Author

@overcat overcat Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed in #306, so there is no action required.

https://github.com/StellarCN/py-stellar-base/blob/dev/stellar_sdk/operation/account_merge.py#L31

@overcat overcat deleted the dev-cap27 branch June 18, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuiles abuiles abuiles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overcat @abuiles