Apply suggestions from code review

uaa-server/README.md

@@ -10,15 +10,15 @@ To run this image locally:
 docker run -it -p 8080:8080 --name steeltoe-uaa steeltoe.azurecr.io/uaa-server:77.10
 ```
 
-## Customizing for your environment
+## Customizing for your Cloud Foundry environment
 
 These instructions will help you build and deploy a custom image to use as an identity provider for [Single Sign-On for VMware Tanzu Application Service](https://docs.vmware.com/en/Single-Sign-On-for-VMware-Tanzu-Application-Service/index.html):
 
 1. Clone this repository.
 1. (Operator task) Create an [identity zone](https://docs.vmware.com/en/VMware-Tanzu-Application-Service/6.0/tas-for-vms/uaa-concepts.html#identity-zones-0)
 1. Change the `redirect-uri` entry for `ssotile` in [uaa.yml](uaa.yml#132) to match your identity zone.
 1. (OPTIONAL) Customize the name of the image you're about to build by renaming the `uaa-server` directory
-1. .\build.ps1 .\uaa-server.
+1. `.\build.ps1 .\uaa-server`.
 1. Push the image to an image repository accessible from your Cloud Foundry environment.
 1. Deploy the image with a command similar to this:
    * `cf push steeltoe-uaa --docker-image steeltoe.azurecr.io/uaa-server:77.10`

uaa-server/uaa.yml

@@ -44,17 +44,17 @@
       menu.read: Permission to read all menu items
       menu.write: Permission to create, update, and delete menu items
       # ----- </Freddy's BBQ> ----- #
-# ----- <Steeltoe Security Samples> ----- #
+      # ----- <Steeltoe Security Samples> ----- #
       sampleapi.read: Permission to access a specific endpoint in the Steeltoe App Security Samples
-# ----- </Steeltoe Security Samples> ----- #
+      # ----- </Steeltoe Security Samples> ----- #
     users:
       # ----- <Freddy's BBQ> ----- #
       - customer|password|[email protected]|Jon|Doe|menu.read,order.me
       - manager|password|[email protected]|Jonathan|Doe|menu.read,menu.write,order.admin
       # ----- </Freddy's BBQ> ----- #
-# ----- <Steeltoe Security Samples> ----- #
+      # ----- <Steeltoe Security Samples> ----- #
       - testuser|password|[email protected]|Jane|Doe|sampleapi.read
-# ----- </Steeltoe Security Samples> ----- #
+      # ----- </Steeltoe Security Samples> ----- #
     userids_enabled: true
     user:
       override: true
@@ -78,7 +78,6 @@
         - roles
         - user_attributes
         - uaa.offline_token
-        - sampleapi.read
     # Always override clients on startup
     client:
       override: true
@@ -105,7 +104,6 @@
         authorities: uaa.resource
         authorized-grant-types: authorization_code
         redirect-uri: http://localhost:8082/login
-        scope: openid,menu.read,order.me
         secret: customerportal_secret
       # ----- </Freddy's BBQ> ---- #
       # --- <Steeltoe Security Samples> --- #