Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: with_suffix to correspond to with_prefix #298

Closed
Borgerr opened this issue Sep 28, 2024 · 1 comment · Fixed by #299
Closed

feature: with_suffix to correspond to with_prefix #298

Borgerr opened this issue Sep 28, 2024 · 1 comment · Fixed by #299

Comments

@Borgerr
Copy link
Contributor

Borgerr commented Sep 28, 2024

Stumbled upon while trying to wrangle some integration testing for a CLI tool, which expects a specific filetype. with_prefix adds a short string to the start of a file's name. We can alter this very cleanly by simply doing some plumbing for adding a short string to the end of the file's name, instead. Builder already has a suffix method which we can leverage for this.

Borgerr added a commit to Borgerr/tempfile that referenced this issue Sep 28, 2024
@Stebalien
Copy link
Owner

Seems reasonable, I'm happy to review a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants