Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump XR Gaming plugin to v0.11.1.5 #674

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

wheaney
Copy link
Contributor

@wheaney wheaney commented Aug 21, 2024

decky-XRGaming

This plugin installs and configures Breezy Vulkan, which provides various features for XR glasses.

This update includes:

  • Support for Rokid Max and Air glasses
  • Support for the new XREAL Air 2 Ultra model in IMU-only mode (no ability to switch to SBS mode)
  • A big reorganization of file placements in Breezy and the base driver package, to conform to XDG standards
  • Migrated the XR Driver systemd service to a user service, it no longer runs as root, though root is still required to run the setup script
  • Moving away from xreal* naming, a holdover from when Breezy and this plugin only supported XREAL glasses
  • Adds a slight delay for VITURE and RayNeo models when they're detected, before attempting to connect, to make the process more reliable for firmware updates that may require a bit more breathing room

All the Breezy changes can be seen in the comparison view between Breezy 0.11.1 and the version currently in the store (0.9.7.2), though since this package is shared with the unrelated Breezy GNOME implementation, I would recommend only looking at the changes to the XR driver module and just the few scripts that affect Breezy Vulkan, by simply searching for changed files with vulkan in the name.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Beta/Preview Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes approved. Good for testing.

@TrainDoctor TrainDoctor requested review from a team August 21, 2024 21:31
@wheaney
Copy link
Contributor Author

wheaney commented Aug 22, 2024

Just pushed an update with a change to the udev rules, they were excluding the newly added XREAL Ultra. Here's the diff: wheaney/XRLinuxDriver@36db133

@wheaney wheaney changed the title Bump XR Gaming plugin to v0.11.1 Bump XR Gaming plugin to v0.11.1.4 Aug 22, 2024
@wheaney
Copy link
Contributor Author

wheaney commented Aug 27, 2024

@TrainDoctor only waiting on approval for the commit linked in my previous comment, which is just updates to udev rules.

@JackfrOst455
Copy link

Decky version(s), SteamOS version(s)
V3.0.0-pre10
3.5.19

A) Any major blocking issues that you encountered, if any.

No issues
B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).

No
C) A list of currently installed plugins (Name and version preferred)
Hltb-1.5.0
Junk store 1.1.7
Non steam launcher. 1.0.1
Moondeck 1.8.0
Xr gaming .11.1.4
Free loader 1.2.1
Vibrant deck 1.0.1

(This list is needed due to potential conflicts between plugins etc).
D) Yay/nay on to send to the production store or if it requires more testing.
Yay

@wheaney
Copy link
Contributor Author

wheaney commented Aug 30, 2024

Please hold off on merging this. Looking into whether I need to fix something from an installation failure.

@wheaney
Copy link
Contributor Author

wheaney commented Aug 30, 2024

Yeah, this is breaking on fresh installs (no previous plugin version installed). I guess all the people I had test were previous users. Fix incoming.

@wheaney
Copy link
Contributor Author

wheaney commented Aug 30, 2024

You can see the fix for v0.11.1.5 by looking at the diff from breezy-desktop v0.11.1.4 to v0.11.1.5. The primary fix was adding the mkdir -p $OLD_BIN_DIR call before trying to copy a file to the bin dir, since the cp syntax is iffy and may create bin as a file in the case where the dir doesn't already exist.

@wheaney wheaney changed the title Bump XR Gaming plugin to v0.11.1.4 Bump XR Gaming plugin to v0.11.1.5 Aug 30, 2024
@wheaney
Copy link
Contributor Author

wheaney commented Sep 3, 2024

@TrainDoctor this is back to you for another small diff linked in my previous comment.

@TrainDoctor
Copy link
Member

@TrainDoctor this is back to you for another small diff linked in my previous comment.

Approved, @JackfrOst455 just needs to confirm latest build works for them and then this can be merged.

@inkahootz
Copy link

Decky version(s) 2.12.3, SteamOS version(s) 3.5.19

A) Any major blocking issues that you encountered, if any.
none
B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
After install when I went back to change modes it gave me the installing message again and got hung up on it. I left the decky screen came back and it was fine. Was not able to replicate the same issue again after that.

C) A list of currently installed plugins (Name and version preferred)
Decky Undervolt 1.0.7
Junk-Store 1.1.7
Steam Grid DB 1.5.1
NonSteamLaunchers 1.0.1

D) Yay/nay on to send to the production store or if it requires more testing.
Yay!

Tested Follow mode in all positions
Adjusted display size

Tested VR Lite
functioned properly
Adjusted mouse sensitivity, appeared to function properly

Tested Virtual display
Size adjustment functioned properly
Follow mode and auto centering functioned properly

Side by side not supported on my glasses

@TrainDoctor TrainDoctor merged commit 7e2261c into SteamDeckHomebrew:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants