Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IntOrString type for disk RPM representation #6

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Conversation

Starttoaster
Copy link
Owner

@Starttoaster Starttoaster commented Sep 20, 2024

For Starttoaster/proxmox-exporter#56

This pull request also fixes a bug where the library responsibly closes the response body, however, that should be up to the user of this library to do it if they capture the http Response object in a variable.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.51%. Comparing base (8689574) to head (a1c6cad).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
request.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   43.85%   47.51%   +3.66%     
==========================================
  Files           5        5              
  Lines         187      181       -6     
==========================================
+ Hits           82       86       +4     
+ Misses         80       70      -10     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Starttoaster Starttoaster changed the title Stop prematurely closing response body Use IntOrString type for disk RPM representation Sep 21, 2024
@Starttoaster Starttoaster merged commit c51bebf into main Sep 21, 2024
1 check passed
@Starttoaster Starttoaster deleted the typefix branch September 21, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants