fix: Making the daemons keep up the status. #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aiden McClelland <[email protected]>
Co-authored-by: Aiden McClelland <[email protected]>
…_svc_effect_handlers
…_svc_effect_handlers
dr-bonez
reviewed
May 10, 2024
| @@ -116,7 +116,7 @@ export class PolyfillEffects implements oet.Effects { | |||
| this.manifest.volumes, | |||
| ) | |||
| const daemon = dockerProcedureContainer.then((dockerProcedureContainer) => | |||
| daemons.runDaemon()( | |||
| daemons.runCommand()( | |||
There was a problem hiding this comment.
So, the reason is that a daemon is something that we start and run. It will keep trying, to run in the background.
A command is something that runs once and is done. This is doing things with a normal command and tries the cleanup that was with the old command.
There was a problem hiding this comment.
ok, as long as this runCommand isn't collecting output, we don't want to be leaking memory buffering logs
| Status::Stopped => context.stopped(), | ||
| SetMainStatusStatus::Running => context.started(), | ||
| SetMainStatusStatus::Stopped => context.stopped(), | ||
| SetMainStatusStatus::Starting => context.stopped(), |
There was a problem hiding this comment.
Why add a varient if just treating as stopped?
There was a problem hiding this comment.
To indicate a state, that it is trying to getting things started. Could be more usefull or not, but for now just not doing anything with this information until I talk with you.
dr-bonez
previously approved these changes
May 10, 2024
dr-bonez
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.