Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tristan/safer sighandler #75

Closed
wants to merge 3 commits into from
Closed

Tristan/safer sighandler #75

wants to merge 3 commits into from

Conversation

tjknoth
Copy link
Contributor

@tjknoth tjknoth commented Apr 21, 2024

This hopefully resolves the issues seen on ARM versions of OSX with the updated signal handlers. The key change is we no longer free unnecessary child process metadata structs in the handler itself. Instead, we filter out the metadata from all dead child processes in calls to launch_process.
As a result, pointers to the metadata struct no longer point to volatile data (though the pointer itself is still volatile).

@tjknoth tjknoth requested a review from CuppoJava April 21, 2024 22:53
@CuppoJava CuppoJava closed this Apr 22, 2024
@CuppoJava CuppoJava deleted the tristan/safer-sighandler branch April 22, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants