Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docutils version 0.16.0 #1087

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

flunka
Copy link
Contributor

@flunka flunka commented Sep 1, 2021

This PR fixes #1080.
Due to some bug in docutils 0.17.0 there are missing caption class in <p> tags.
Pindocutils to version 0.16.0 solves the issue.
This is similar issue like here readthedocs/sphinx_rtd_theme#1111

@flunka flunka marked this pull request as ready for review September 1, 2021 17:29
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the other issues. Using docutils 0.17 is fixed with sphinx 3.5+, but we are using sphinx <3.0 so pinning docutils is a good thing to do.

@cognifloyd cognifloyd merged commit 61df5d4 into StackStorm:master Sep 1, 2021
@arm4b
Copy link
Member

arm4b commented Sep 1, 2021

@flunka Thanks a lot for the contribution!
First PR and so helpful fix! 👍

Can you also cherry-pick the same change for the https://github.com/StackStorm/st2docs/tree/v3.5 branch?
This way it'll fix it for stable documentation branch: https://docs.stackstorm.com/3.5/ too.

@flunka
Copy link
Contributor Author

flunka commented Sep 1, 2021

I'm glad I could help.
I've created #1088 for v3.5 branch.

cognifloyd added a commit that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some part of captions are missing on the left side navigation menu.
3 participants