-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace most print()s with logging calls #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminaubin
suggested changes
Jul 25, 2023
benjaminaubin
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thank you
jenuk
pushed a commit
that referenced
this pull request
Jul 26, 2023
akx
added a commit
to akx/generative-models
that referenced
this pull request
Jul 27, 2023
This is a rebase of Stability-AI#42 after it was reverted, and includes the fix from Stability-AI#64.
akx
added a commit
to akx/generative-models
that referenced
this pull request
Sep 26, 2023
This is a rebase of Stability-AI#42 after it was reverted, and includes the fix from Stability-AI#64.
LinearFalcon
pushed a commit
to LinearFalcon/generative-models
that referenced
this pull request
Jul 6, 2024
LinearFalcon
pushed a commit
to LinearFalcon/generative-models
that referenced
this pull request
Jul 6, 2024
…tability-AI#65) This reverts commit 6f6d3f8.
SevanBrodjian
pushed a commit
to SevanBrodjian/sd-latent-exploration
that referenced
this pull request
Aug 12, 2024
SevanBrodjian
pushed a commit
to SevanBrodjian/sd-latent-exploration
that referenced
this pull request
Aug 12, 2024
…tability-AI#65) This reverts commit 6f6d3f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
print()
calls in class constructors, etc. with standardlogging
calls, to make it easier for downstream repositories to control the verbosity of the library without having to resort to patches such as replacingprint
in these modules.