Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace most print()s with logging calls #42

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Jul 17, 2023

This replaces print() calls in class constructors, etc. with standard logging calls, to make it easier for downstream repositories to control the verbosity of the library without having to resort to patches such as replacing print in these modules.

sgm/data/dataset.py Outdated Show resolved Hide resolved
Copy link
Contributor

@benjaminaubin benjaminaubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you

@benjaminaubin benjaminaubin merged commit 6f6d3f8 into Stability-AI:main Jul 25, 2023
@akx akx mentioned this pull request Jul 26, 2023
jenuk added a commit that referenced this pull request Jul 26, 2023
jenuk pushed a commit that referenced this pull request Jul 26, 2023
akx added a commit to akx/generative-models that referenced this pull request Jul 27, 2023
This is a rebase of Stability-AI#42 after it was reverted,
and includes the fix from Stability-AI#64.
akx added a commit to akx/generative-models that referenced this pull request Sep 26, 2023
This is a rebase of Stability-AI#42 after it was reverted,
and includes the fix from Stability-AI#64.
LinearFalcon pushed a commit to LinearFalcon/generative-models that referenced this pull request Jul 6, 2024
LinearFalcon pushed a commit to LinearFalcon/generative-models that referenced this pull request Jul 6, 2024
SevanBrodjian pushed a commit to SevanBrodjian/sd-latent-exploration that referenced this pull request Aug 12, 2024
SevanBrodjian pushed a commit to SevanBrodjian/sd-latent-exploration that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants