Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels using cibuildwheel #100

Closed
wants to merge 13 commits into from
Closed

Conversation

Czaki
Copy link

@Czaki Czaki commented Sep 20, 2021

This PR adds building wheels using cibuildwheel which simplifies creating wheels and adds support for Linux wheels. It also changes macOS wheels from x86_64 to universal2 (to work on m1 machine).

I do not found an option to run tests on CI.

Here sample run https://github.com/Czaki/python-rtmidi/actions/runs/1253787788

@SpotlightKid
Copy link
Owner

Many thanks for the PR. I'll be on holiday next week and hop to to find the time to have a look at it then. Thanks for your work and patience.

@ntamas
Copy link

ntamas commented Dec 3, 2021

@SpotlightKid Did you have a chance to look at this PR? It would be great to have a new set of wheels on PyPI as Python 3.10 has been released; also, I currently need to compile from source on Apple Silicon. Thanks a lot!

@SpotlightKid
Copy link
Owner

@ntamas Not in detail yet, sorry. I'm away for the weekend, but I'll try to look at it next week. At first glance it looks good, though.

@ntamas
Copy link

ntamas commented Dec 6, 2021

Thanks! In the meanwhile I tried the PR In my own fork and it seems like it still works nicely and generates correct wheels for Win32, macOS and Linux; see here.

@Czaki
Copy link
Author

Czaki commented Dec 6, 2021

Just updated to the last release of cibuildwheel.
Disable musllinux wheels as it fails to detect pthread. I do not know if this check should be performed on musllinux (it may be built-in muslc).

https://github.com/Czaki/python-rtmidi/actions/runs/1545141326

@Bubobubobubobubo
Copy link

@SpotlightKid: can we proceed further with the integration of cibuildwheel?
This would greatly simplify the installation process of many rtmidi dependant code bases.

@georgeharker
Copy link
Contributor

I'd love to see this in mainline - it fixes issues building for python 3.11

@Czaki Czaki marked this pull request as draft April 19, 2023 07:07
@brunoenten
Copy link
Collaborator

Thanks for your contribution. It was probably used to create PR #119, superseding this one.

@brunoenten brunoenten closed this May 21, 2023
@Czaki
Copy link
Author

Czaki commented May 21, 2023

As last time I check the #119 was failing so I kept it to make some wheel available for some folks.

If you need help with cibuildwheel feel free to ping

@brunoenten
Copy link
Collaborator

True but it was superseded by #121 which fixed the cibuildwheel that remained.
Both PR clearly used your work as a basis, so thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants