-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build wheels using cibuildwheel #100
Conversation
Many thanks for the PR. I'll be on holiday next week and hop to to find the time to have a look at it then. Thanks for your work and patience. |
@SpotlightKid Did you have a chance to look at this PR? It would be great to have a new set of wheels on PyPI as Python 3.10 has been released; also, I currently need to compile from source on Apple Silicon. Thanks a lot! |
@ntamas Not in detail yet, sorry. I'm away for the weekend, but I'll try to look at it next week. At first glance it looks good, though. |
Thanks! In the meanwhile I tried the PR In my own fork and it seems like it still works nicely and generates correct wheels for Win32, macOS and Linux; see here. |
Just updated to the last release of cibuildwheel. https://github.com/Czaki/python-rtmidi/actions/runs/1545141326 |
@SpotlightKid: can we proceed further with the integration of |
I'd love to see this in mainline - it fixes issues building for python 3.11 |
Thanks for your contribution. It was probably used to create PR #119, superseding this one. |
As last time I check the #119 was failing so I kept it to make some wheel available for some folks. If you need help with cibuildwheel feel free to ping |
True but it was superseded by #121 which fixed the cibuildwheel that remained. |
This PR adds building wheels using cibuildwheel which simplifies creating wheels and adds support for Linux wheels. It also changes macOS wheels from x86_64 to universal2 (to work on m1 machine).
I do not found an option to run tests on CI.
Here sample run https://github.com/Czaki/python-rtmidi/actions/runs/1253787788