Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new device types #1316

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Add new device types #1316

merged 3 commits into from
Dec 27, 2024

Conversation

dotandl
Copy link
Contributor

@dotandl dotandl commented Dec 19, 2024

spotifyd was lacking new device types (such as automobile, gameconsole etc.) introduced some time ago in librespot.

eladyn
eladyn previously approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some minor comment that you can address, if you want, but otherwise I'd be ready to merge.

eladyn
eladyn approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, awesome!

@eladyn eladyn merged commit c6e6af4 into Spotifyd:master Dec 27, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladyn eladyn eladyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotandl @eladyn