-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GitHub.auth non-nullable #377
Conversation
We'll want a changelog entry here, right? |
Changelog entries are generated by the GitHub action |
@robbecker-wf can you help release this? \cc @ricardoamador |
Released in version 9.15.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.15.0 |
I don't mind making this non-nullable, but can we restore making it mutable? GitHub credentials regularly need to be refreshed and having to recreate a whole new |
Out of curiosity, do you have sample code I could take a look at? This seems like a fair request, but I was under the impression most callers will recreate the entire client instead of re-minting the auth. |
For the most part, this is already non-nullable.
See flutter/flutter#129134 - This should help with debugging why our server is getting a null auth state.