Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calendar versioning #338

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Add calendar versioning #338

merged 1 commit into from
Nov 30, 2022

Conversation

CaseyHillers
Copy link
Collaborator

No description provided.

@CaseyHillers CaseyHillers added the semver:minor Non-Breaking Public API Changes (additions) label Nov 29, 2022
CaseyHillers
CaseyHillers commented Nov 29, 2022
View reviewed changes
lib/src/common/github.dart
///
/// See also:
/// * https://docs.github.com/en/rest/overview/api-versions?apiVersion=2022-11-28
final String version;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this change was me debating if we should make this private. I lean towards making it public to give an easy escape hatch for downstream dependencies to override what the library is using.

kevmoo
kevmoo approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a changelog entry here?

@CaseyHillers
Copy link
Collaborator Author

Do we want a changelog entry here?

Based on https://semver.org/#spec-item-7, that's expected. We're adding version to the main entry point of this library.

I can't recall if the release automation generates the changelog entries, so I opt'd to add it here.

@kevmoo
Copy link
Collaborator

kevmoo commented Nov 30, 2022

Do we want a changelog entry here?

Based on https://semver.org/#spec-item-7, that's expected. We're adding version to the main entry point of this library.

I can't recall if the release automation generates the changelog entries, so I opt'd to add it here.

Auto-magic drives me nuts. Okay.

@robrbecker
Copy link
Member

Yep, The changelog and version will be updated automatically after this merges.

@robrbecker robrbecker merged commit e9230e6 into SpinlockLabs:master Nov 30, 2022
@robrbecker
Copy link
Member

Released in version 9.7.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.7.0

@CaseyHillers CaseyHillers linked an issue Feb 15, 2023 that may be closed by this pull request
Support GitHub's v3 API date based versioning #337
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@robrbecker robrbecker robrbecker approved these changes

@robbecker-wf robbecker-wf Awaiting requested review from robbecker-wf

Assignees
No one assigned
Labels
released semver:minor Non-Breaking Public API Changes (additions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GitHub's v3 API date based versioning
3 participants
@CaseyHillers @kevmoo @robrbecker