-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'create' github webhook event to hooks.dart #304
add 'create' github webhook event to hooks.dart #304
Conversation
seems like I can't add reviewers. cc @CaseyHillers and @keyonghan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires an update to the changelog and increase the Y version
User? sender; | ||
|
||
Map<String, dynamic> toJson() => _$CreateEventToJson(this); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, added
You'll need to update |
@CaseyHillers Actually, I've set up auto-release on PR merge, so updating the changelog and version in the pubspec happens automatically after merge based on the semver label. So the PR itself should not update those files. |
That is fancier than I imagined since we last talked about it :-) Nice work! @XilaiZhang feel free to disregard my comment. However, there's some formatting issues |
@XilaiZhang it does look like the test file you added needs to be formatted. Use |
Thanks for the instructions! (Also thanks for providing the format commands, previously I used the same format command for flutter/cocoon and formatted like 132 files :) and reverted |
The create webhook event and its payloads are described here at : https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#create
The tests seem to fail pretty significantly but I looked around and they seem unrelated to this change, but are failing because of existing codes?