Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default language color #208

Merged
merged 3 commits into from
Feb 9, 2020
Merged

Update default language color #208

merged 3 commits into from
Feb 9, 2020

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Feb 8, 2020

Make it consistent with GitHub

Example here: https://github.com/apache/thrift

image

robrbecker
robrbecker approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@robrbecker robrbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Any more changes or is it ready to merge?

@pd4d10
Copy link
Contributor Author

pd4d10 commented Feb 9, 2020

Thanks for your review! I think it is ready to merge if these changes are considered to be reasonable

@robrbecker robrbecker merged commit 579fd78 into SpinlockLabs:master Feb 9, 2020
@robrbecker
Copy link
Member

Released in 6.1.2

@pd4d10 pd4d10 deleted the patch-1 branch February 18, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrbecker robrbecker robrbecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pd4d10 @robrbecker