Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateFile request must be a PUT #160

Merged
merged 2 commits into from
Sep 20, 2019
Merged

updateFile request must be a PUT #160

merged 2 commits into from
Sep 20, 2019

Conversation

comigor
Copy link
Contributor

@comigor comigor commented Aug 31, 2019

I was trying to use this API but ended up with Not Found messages. While debugging, I've discovered updatefile request must be done with PUT command (and not POST, as this library was doing).

Warning: there may be otherrequests that must be done with PUT method!

robbecker-wf
robbecker-wf approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for finding this and putting up a PR!

@robbecker-wf robbecker-wf merged commit 88a63f7 into SpinlockLabs:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbecker-wf robbecker-wf robbecker-wf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comigor @robbecker-wf