Improvements for testing utils (Part 3) #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Simplify code flow for reading. * Reorder ctor. parameters.
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
=========================================
Coverage 91.06% 91.06%
Complexity 4639 4639
=========================================
Files 596 596
Lines 14678 14678
Branches 831 831
=========================================
Hits 13367 13367
Misses 1048 1048
Partials 263 263 |
Also: * Simplify the naming removing `Bounded` infix.
Also: * Fix generic params in the API to avoid the `rawtypes` warning.
Commands, command messages, events, and event messages can be accessed via `assertCommands()` and `assertEvents()` correspondingly.
8 tasks
testutil-server/src/main/java/io/spine/testing/server/blackbox/Actor.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxContext.java
Show resolved
Hide resolved
dmdashenkov
suggested changes
Mar 22, 2020
server/src/test/java/io/spine/server/projection/ProjectionTest.java
Outdated
Show resolved
Hide resolved
testutil-client/src/main/java/io/spine/testing/client/TestActorRequestFactory.java
Outdated
Show resolved
Hide resolved
dmdashenkov
approved these changes
Mar 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following improvement:
@Internalmethods ofBoundedContextmoved to its internal classInternalAccessinstance of which is available via theinternalAccess()method.The method is available only to the server-side framework code.
BlackBoxBoundedContextwas renamed toBlackBoxContext.BlackBoxContextfromBoundedContextBuilderwas simplified.UserIdandZoneIdparameters ofBlackBoxContext.TestActorRequestFactoryno longer requiresZoneOffset. It's calculated fromZoneId.BlackBoxCountext.TestEventFactory.