Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infix file pattern #330

Merged
merged 24 commits into from
Feb 22, 2025
Merged

Infix file pattern #330

merged 24 commits into from
Feb 22, 2025

Conversation

alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Feb 21, 2025

This PR introduces FilePattern.infix property which aims to replace the prefix property.

ProtoData started using absolute file paths for types implementing ProtoDeclaration. This is to allow navigatable full file paths when reporting compilation errors. Because of this prefix pattern makes little sense because figuring out absolute paths on developer workstations would be awkward and meaningless.

Other notable changes

  • The File type got (pattern).regex option prohibiting Windows path separators.
  • Similarly to File, the Directory type also got validation option for requiring Unix path separators.
  • Functions converting Files and Paths got names clarifying where the output is definitely absolute.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Feb 21, 2025
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review February 21, 2025 19:55
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.07%. Comparing base (ff7faf1) to head (20fc512).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage     76.07%   76.07%           
- Complexity      558      560    +2     
=========================================
  Files           192      192           
  Lines          4158     4168   +10     
  Branches        392      392           
=========================================
+ Hits           3163     3171    +8     
- Misses          863      865    +2     
  Partials        132      132           

@alexander-yevsyukov alexander-yevsyukov merged commit 50f3870 into master Feb 22, 2025
8 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the infix-file-pattern branch February 22, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants