-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infix file pattern #330
Merged
Merged
Infix file pattern #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=========================================
Coverage 76.07% 76.07%
- Complexity 558 560 +2
=========================================
Files 192 192
Lines 4158 4168 +10
Branches 392 392
=========================================
+ Hits 3163 3171 +8
- Misses 863 865 +2
Partials 132 132 |
armiol
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
FilePattern.infix
property which aims to replace theprefix
property.ProtoData started using absolute file paths for types implementing
ProtoDeclaration
. This is to allow navigatable full file paths when reporting compilation errors. Because of thisprefix
pattern makes little sense because figuring out absolute paths on developer workstations would be awkward and meaningless.Other notable changes
File
type got(pattern).regex
option prohibiting Windows path separators.File
, theDirectory
type also got validation option for requiring Unix path separators.File
s andPath
s got names clarifying where the output is definitely absolute.