Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with obtaining Resource Reviews #47

Closed
MrEAlderson opened this issue Dec 23, 2021 · 1 comment
Closed

Issues with obtaining Resource Reviews #47

MrEAlderson opened this issue Dec 23, 2021 · 1 comment

Comments

@MrEAlderson
Copy link

Hey,
first of all thank you for creating this wonderful project.
However, there two bugs with the the "Resource Reviews" API, which I already addressed in your Discord:

  1. The "responseMessage" is never present
  2. "rating.count" returns always 1. The average seems to be correct tho, if it's supposed to represent the average count given by the user.
InventivetalentDev added a commit to SpiGetOrg/api.spiget.org that referenced this issue Dec 27, 2021
@InventivetalentDev
fix missing response message (SpiGetOrg/Spiget#47)
8b0c907
@InventivetalentDev
Copy link
Member

  1. was an issue with the api, should be fixed soon :)

  2. the count is intended to be 1 in the context of /resources/{}/reviews since it's only for a single review (use the number of objects in the returned array for the actual count). in /resources/{} it's the number of reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@InventivetalentDev @MrEAlderson