Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add PhysicalAddress migrations to postgres #181

Conversation

jcmelati
Copy link
Contributor

No description provided.

Copy link
Contributor

@BtencateSphereon BtencateSphereon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we released any products yet that use the migrations to production, so please update the existing migration to include the table. This so we keep the complexity down.

Besides that, please look at the naming conventions we use. and use this PR to sync the changes made for sqlite for postgress so we keep them the same.

#161

@BtencateSphereon
Copy link
Contributor

we do have the mobile wallet in the review process, but since this is using sqlite, i do not think this will impact the needed change for postgres. So i would say it is still safe to update the latest postgres migration, instead of making a new migration file. But we need to double check with @nklomp

@jcmelati jcmelati closed this Apr 10, 2024
@nklomp
Copy link
Contributor

nklomp commented Apr 10, 2024

Yeah I am still okay with updating it for sqlite at this point. We are at 0.2 and moved to a completely different kv store forcing users to reonboard anyway. Once we are getting closer to 1.0 we will change of course to have new migration files for every single change

@jcmelati jcmelati reopened this Apr 10, 2024
@jcmelati jcmelati force-pushed the SDK-9-Fix-data-store-package-Postgres-migrations-to-include-missing-entities branch from 97da70e to 38318ae Compare April 10, 2024 12:36
@jcmelati jcmelati merged commit e4407df into develop Apr 12, 2024
1 check passed
@BtencateSphereon BtencateSphereon deleted the SDK-9-Fix-data-store-package-Postgres-migrations-to-include-missing-entities branch April 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants