Skip to content

Commit

Permalink
Object Spaces: when building need to now make serializer if not speci…
Browse files Browse the repository at this point in the history
…fied
  • Loading branch information
HermanSchoenfeld committed May 27, 2024
1 parent 57201c1 commit e0675fe
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/Hydrogen/ObjectSpaces/Builder/ObjectSpaceBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ public ObjectSpaceBuilder UsingSerializerFactory(SerializerFactory factory) {
return this;
}

public bool ContainsSerializer<TItem>() => ContainsSerializer(typeof(TItem));

public bool ContainsSerializer(Type type) => _serializerFactory.ContainsSerializer(type);

public ObjectSpaceBuilder UsingSerializer<TItem, TItemSerializer>() where TItemSerializer : IItemSerializer<TItem>, new() {
Guard.Against(_usingCustomSerializerFactory, ErrMsgUsingSerializer);
_specifiedCustomSerializer = true;
Expand All @@ -155,6 +159,15 @@ public ObjectSpaceBuilder UsingSerializer<TItem>(IItemSerializer<TItem> serializ
return this;
}

public ObjectSpaceBuilder MakeSerializer<TItem>() => MakeSerializer(typeof(TItem));

public ObjectSpaceBuilder MakeSerializer(Type type) {
Guard.Ensure(!_serializerFactory.ContainsSerializer(type), $"Serializer for type {type.ToStringCS()} has already been registered.");
_specifiedCustomSerializer = true;
_serializerFactory.RegisterAutoBuild(type);
return this;
}

public ObjectSpaceBuilder UsingComparerFactory(ComparerFactory factory) {
Guard.ArgumentNotNull(factory, nameof(factory));
Guard.Against(_specifiedCustomComparer, ErrMsgUseComparerFactory);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ public ObjectSpaceDimensionBuilder<T> UsingSerializer(IItemSerializer<T> seriali
return this;
}

public ObjectSpaceDimensionBuilder<T> MakeSerializer() {
_parent.MakeSerializer<T>();
return this;
}

public ObjectSpaceDimensionBuilder<T> UsingComparer<TComparer>() where TComparer : IComparer<T>, new() {
_parent.UsingComparer<T, TComparer>();
return this;
Expand Down Expand Up @@ -161,6 +166,8 @@ public ObjectSpaceDimensionBuilder<T> OptimizeAssumingAverageItemSize(int bytes)
}

public ObjectSpaceBuilder Done() {
if (!_parent.ContainsSerializer(typeof(T)))
MakeSerializer();
return _parent;
}

Expand Down

0 comments on commit e0675fe

Please sign in to comment.