Reorganize namespaces #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr229
approved these changes
Feb 8, 2022
|
Just wanna let you know this is a BREAKING change so you might want to inform about this |
|
Oh yeah I should change the version number in this PR as well |
|
just hold onto it and do a full release (3.0.0) including #13 |
|
Yup, that's precisely my intention |
|
Let me know what you think of how I reorganized this |
|
Looks like this is a cleaner API, definitely a good change. |
|
Yay :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes weren't really organized well before. Let me know what you think about this.