Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5311 fix: incorrect oidc cookie consumption #1083

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

mistahj67
Copy link
Contributor

Description

  • Always delete auth cookies in callback
  • Fix incorrect sameSite flag for OIDC cross-site cookies

Motivation and Context

This PR addresses: BED-5311

Why is this change required? What problem does it solve?
One cannot login via OIDC in it's current state

How Has This Been Tested?

Locally against a self-signed cert to mimic prod as closely as possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Jan 16, 2025
@mistahj67 mistahj67 self-assigned this Jan 16, 2025
@mistahj67 mistahj67 added the bug Something isn't working label Jan 16, 2025
@mistahj67 mistahj67 changed the base branch from main to stage/v6.4.1 January 16, 2025 02:48
Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out. Some good refactor in here as well. Pull!

@mistahj67 mistahj67 merged commit 71701e0 into stage/v6.4.1 Jan 16, 2025
5 checks passed
@mistahj67 mistahj67 deleted the BED-5311 branch January 16, 2025 17:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants