chore(ffe-searchable-dropdown-react)!: remove HighCapacity #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apacity SearchableDropdownHighCapacity depends on react-virtualization; a package which is no longer maintained and does not work seamlessly with modern build tools such as vite. BREAKING CHANGE: SearchableDropdownHighCapacity is no longer exported.
antidecaf
approved these changes
Sep 1, 2023
|
Takk for at du tok denne ryddejobben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove exported component SearchableDropdownHighCapacity.
SearchableDropdownHighCapacity depends on react-virtualization; a package which is no longer maintained and does not work seamlessly with modern build tools such as vite.
BREAKING CHANGE: SearchableDropdownHighCapacity is no longer exported.
Beskrivelse
Fjerner komponenten SearchableDropdownHighCapacity
Motivasjon og kontekst
Komponenten er den siste av komponentene i designsystemet som avhenger av react-virtualization; et lib som ikke lenger vedlikeholdes og som ikke kan bygges med vite.js uten hacks. Ettersom SearchableDropdownHighCapacity heller ikke er i bruk av noen (i det minste i SB1), kan vi like gjerne ta den bort.
Testing