-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tvOS via SPM #494
Support tvOS via SPM #494
Conversation
@andresilveirah Did you already have some time to have a first look at the MR? |
Hi @asshoffm just got back from a looong vacation. Looking into your MR now. |
@asshoffm I know it's a bit of an effort, but do you mind opening a PR with only the changes necessary to introduce support to SPM for tvOS (ie. keeping iOS and tvOS minimum version down to 10, not running pod install nor the scripts to update/create the XCFrameworks). |
…implementationOnly for the SPM build since the compiler cannot resolve the dependency otherwise. See https://forums.swift.org/t/update-on-implementation-only-imports/26996.
…trivial to have regular targets)
@andresilveirah Updated the MR 👍🏻 But to be able to test it, you now need to run the build script first. |
@asshoffm thank you, appreciate you taking the time to submit the PR. I moved the code with the generated XCFrameworks to a branch called Can you give it a final try using branch |
I tested your branch. On tvOS, we get the error However it should still prove that the framework is built and integrated correctly. So yes, both iOS and tvOs work via SPM 👍🏻 |
@andresilveirah Are there still open points on your side? |
@asshoffm I've been fighting with XCode 15.0.1 for the last week or so. I was ready to merge, but decided to update XCode and after that the SPM XCFramework stopped archiving via command line. I think I finally found a solution, just running final tests again and, if it's all good, I'll create a release today still. |
Hi! 👋
This MR adds tvOS support to the distribution via SPM.
Because of the XIBs for tvOS, it is not trivial to have regular targets. Therefore, the framework is now built and distributed as a binary framework.
The import of
Down
is changed to@_implementationOnly
for the SPM build since the compiler cannot resolve the dependency otherwise. See https://forums.swift.org/t/update-on-implementation-only-imports/26996.The changes do not affect the distribution of cocoa pods and the existing binary frameworks.
For future updates, you only need to run the spm script which generates the SPM binaries.
The supported tvOS and iOS versions are also bumped for Xcode 14 compatibility.