Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown support to tvOS #466

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

andresilveirah
Copy link
Member

@andresilveirah andresilveirah commented Jul 24, 2023

Changes this:
Screenshot 2023-07-24 at 21 16 50

To this:
Screenshot 2023-07-24 at 21 15 39

@andresilveirah
Copy link
Member Author

@Nevazhnovu don't let the number of files intimidate you. We have a lot of new files because of a new dependency Down to handle Markdown on tvOS.

@andresilveirah andresilveirah changed the base branch from develop to DIA-1689_v6_consent_not_transferring_webview July 25, 2023 12:56
@andresilveirah andresilveirah changed the base branch from DIA-1689_v6_consent_not_transferring_webview to develop July 25, 2023 12:56
- ConsentViewController (7.2.1)
- ConsentViewController (7.2.1):
- Down (~> 0.9.0)
- Down (0.9.5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresilveirah is it alright that we have two Down dependencies but with different versions in the Podfile?

Copy link
Member Author

@andresilveirah andresilveirah Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nevazhnovu yes.
The notation ~> X.Y.Z means use the latest version as long as X and Y are the ones specified (so Z can be as high as possible.
If you specify ~> X.Y it'd mean, use the latest version as long as X is the one specified and Y can go as high as possible.

https://guides.cocoapods.org/syntax/podfile.html#pod

@andresilveirah andresilveirah merged commit 99682cf into develop Jul 25, 2023
@andresilveirah andresilveirah deleted the add_markdown_parser_to_tvOS branch July 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants