[DIA-2061] childPmId is saved to UserDefaults when it comes in /meta-data response
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meta-data` response
|
@andresilveirah this PR is ready for review! |
|
@Nevazhnovu I believe this PR doesn't contain enough tests to cover this feature. Here you're only testing that |
Example/ConsentViewController_ExampleTests/SPClientCoordinator/SPClientCoordinatorSpec.swift
Show resolved
Hide resolved
| @@ -196,6 +196,28 @@ class UnmockedSourcepointClientSpec: QuickSpec { | |||
| } | |||
| } | |||
|
|
|||
| describe("meta-data_groupPmId") { | |||
| it("Check if groupPmId echo") { | |||
There was a problem hiding this comment.
Same goes here, since we already have a describe("meta-data") you don't need to duplicate it, you can simply add the new it("... to the existing describe a few lines above.
| @@ -42,8 +42,45 @@ class SPClientCoordinatorSpec: QuickSpec { | |||
| ) | |||
| } | |||
|
|
|||
| describe("selectPrivacyManagerId") { | |||
There was a problem hiding this comment.
@Nevazhnovu I believe this test doesn't belong to SPClientCoordinatorSpec, but rather SPConsentManagerSpec (feel free to create the file if that doesn't exist yet).
andresilveirah
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
childPmIdno longer comes from messageschildPmIdwhich comes from/meta-datatoUserDefaultschildPmId