Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DIA-2137] update error codes #442

Merged
merged 16 commits into from
May 24, 2023
Merged

[DIA-2137] update error codes #442

merged 16 commits into from
May 24, 2023

Conversation

Nevazhnovu
Copy link
Collaborator

No description provided.

@Nevazhnovu Nevazhnovu requested a review from andresilveirah May 16, 2023 10:45
Nevazhnovu added 6 commits May 18, 2023 17:28
@Nevazhnovu
[DIA-2137] sp_metric_resource_not_found_4xx and `sp_metric_internal…
e58193b 
…_server_error_5xx` error codes are deleted
@Nevazhnovu
[DIA-2137] error code `sp_metric_generic_network_request_\(response?.…
ee7cb11 
…statusCode ?? 999)` refactored to `sp_metric_url_loading_error` to conform to Android error code.
@Nevazhnovu
[DIA-2137] error code sp_metric_invalid_request_error became concre…
7fc8735 
…te `sp_metric_invalid_consent_UUID`
@Nevazhnovu
[DIA-2137] error code sp_metric_connection_timeout refactored to ha…
28387fb 
…ve concrete ending added depending of what API it is addressed: `_meta-data` or `_consent-status` or `_pv-data` or `_messages`
@Nevazhnovu
[DIA-2137] unit tests fixed
a084309
@Nevazhnovu
[DIA-2137] revert unneccessary change
06597b6
@Nevazhnovu Nevazhnovu marked this pull request as ready for review May 22, 2023 10:30
@Nevazhnovu
Copy link
Collaborator Author

@andresilveirah please review.
@bohdan-go-wombat you can do it too if you want, it is optional. Here is changes of SP error codes, the same error codes exist in Android as well.

andresilveirah
andresilveirah reviewed May 22, 2023
View reviewed changes
@Nevazhnovu Nevazhnovu requested a review from andresilveirah May 22, 2023 11:59
@Nevazhnovu Nevazhnovu requested a review from andresilveirah May 23, 2023 11:13
@Nevazhnovu
Copy link
Collaborator Author

@andresilveirah done

@Nevazhnovu Nevazhnovu merged commit edcbe4b into develop May 24, 2023
@Nevazhnovu Nevazhnovu deleted the DIA-2137_update_error_codes branch May 24, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresilveirah andresilveirah Awaiting requested review from andresilveirah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nevazhnovu @andresilveirah