Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIA-2065 / DIA-2120 fix state management for authenticated consent and handle pv-data response #430

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

andresilveirah
Copy link
Member

This PR addresses 2 items:

State management when authId changes

The SDK now correctly implements the following logic, related to state management when authId changes:

  1. authId changes from nil -> "something": state is persisted (consent is then linked to the current uuid)
  2. authId changes from "something" -> nil: state is persisted (stored authId remains "something")
  3. authId changes from "something" -> "something else": state is reset (and authId becomes "something else")

Handling /pv-data response

The /pv-data endpoint not only logs a "pageview" but also returns a new consent uuid for a given campaign.

Previously the SDK would not wait for the response of /pv-data. And this causes issues with reporting as well as a missing consent uuid in the stored consent data (until the user takes a consent action).

@andresilveirah andresilveirah changed the title DIA-2065 fix state management for authenticated consent DIA-2065 / DIA-2120 fix state management for authenticated consent and handle pv-data response Apr 26, 2023
@andresilveirah andresilveirah merged commit 3bd819c into develop Apr 27, 2023
@andresilveirah andresilveirah deleted the DIA-2065_auth_consent_ccpa branch April 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant