Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP-8562 appletv wrong cell focus UI test fix #361

Merged
merged 9 commits into from
Feb 8, 2022

Conversation

Nevazhnovu
Copy link
Collaborator

No description provided.

@andresilveirah
Copy link
Member

@Nevazhnovu 👍 for the PR. What do you think of "encapsulating" all the XCUIRemote.shared.press into descriptive methods. Example, let's say you want to select a given vendor from the vendor table, instead of:

XCUIRemote.shared.press(.up)
XCUIRemote.shared.press(.select)
...

We'd have:

// app class
func selectVendor() {
  XCUIRemote.shared.press(.up)
  XCUIRemote.shared.press(.select)
}

// inside the test cases
self.app.vendorsScreen.selectVendor()

…criptive methods inside 'NativePMApp' extension
* develop:
  add a note about the onAction running sync
  run onAction callback on the main thread
  add pubData to loadMessage method
  add pubData to messages request
  implement SPPublisherData class
@Nevazhnovu Nevazhnovu merged commit 2a2bcd9 into develop Feb 8, 2022
@andresilveirah andresilveirah deleted the SP-8562_appletv_wrong_cell_focus_ui_test_fix branch February 8, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants