Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SP-8654 fix SPM build #360

Merged
merged 7 commits into from
Feb 1, 2022
Merged

SP-8654 fix SPM build #360

merged 7 commits into from
Feb 1, 2022

Conversation

andresilveirah
Copy link
Member

@andresilveirah andresilveirah commented Feb 1, 2022 •
edited
Loading

  • added a target (SPMBuild) just to make sure the Swift Package is building
  • added missing import UIKit to Constants.swift
  • namespace Constants with Constants.Urls and Constants.UI
  • fix linting
  • fix 2 unit tests

@Nevazhnovu
Copy link
Collaborator

@andresilveirah do you know why brand new Test / BuildSwiftPackage is falling and Test / ObjC-ExampleApp-tests started failing too?

@andresilveirah
Copy link
Member Author

Fixes #359

@andresilveirah andresilveirah merged commit db80e4d into develop Feb 1, 2022
@andresilveirah andresilveirah deleted the SP-8654_fix_SPM_build branch February 1, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevazhnovu Nevazhnovu Nevazhnovu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresilveirah @Nevazhnovu