Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1436 Analysis in CLion on Windows does not work #1074

Merged
merged 2 commits into from
May 31, 2024
Merged

SLI-1436 Analysis in CLion on Windows does not work #1074

merged 2 commits into from
May 31, 2024

Conversation

nquinquenel
Copy link
Member

No description provided.

@nquinquenel nquinquenel marked this pull request as ready for review May 31, 2024 10:02
damien-urruty-sonarsource
damien-urruty-sonarsource approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works for most cases, except remote FS. Not sure we need to support this case

src/main/java/org/sonarlint/intellij/util/VirtualFileUtils.kt Outdated Show resolved Hide resolved
@nquinquenel nquinquenel force-pushed the fix/nq/SLI-1436-windows-path branch from 0b4d005 to 6bd0642 Compare May 31, 2024 12:45
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nquinquenel nquinquenel merged commit 1f82f61 into master May 31, 2024
18 checks passed
@nquinquenel nquinquenel deleted the fix/nq/SLI-1436-windows-path branch May 31, 2024 13:33
nquinquenel added a commit that referenced this pull request May 31, 2024
@nquinquenel
SLI-1436 Analysis in CLion on Windows does not work (#1074)
9cc2277
nquinquenel added a commit that referenced this pull request May 31, 2024
@nquinquenel
SLI-1436 Analysis in CLion on Windows does not work (#1074)
7000edd
nquinquenel added a commit that referenced this pull request May 31, 2024
@nquinquenel
SLI-1436 Analysis in CLion on Windows does not work (#1074)
6090ec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damien-urruty-sonarsource damien-urruty-sonarsource damien-urruty-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquinquenel @damien-urruty-sonarsource