Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCANNPM-61 Hint support for NO_PROXY in proxy examples #183

Merged
merged 1 commit into from
Dec 12, 2024
Merged

SCANNPM-61 Hint support for NO_PROXY in proxy examples #183

merged 1 commit into from
Dec 12, 2024

Conversation

7PH
Copy link

@7PH 7PH commented Dec 9, 2024 •
edited
Loading

@7PH 7PH force-pushed the doc/br/scannpm-61-no-proxy branch 3 times, most recently from 975ef64 to ff9d2d3 Compare December 9, 2024 09:43
@7PH 7PH requested review from a team and lucas-paulger-sonarsource December 9, 2024 09:48
lucas-paulger-sonarsource
lucas-paulger-sonarsource approved these changes Dec 9, 2024
View reviewed changes
Copy link

@lucas-paulger-sonarsource lucas-paulger-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kebetsi
kebetsi approved these changes Dec 10, 2024
View reviewed changes
Copy link

@kebetsi kebetsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking:
If I understand, no_proxy allows to define a domain for which the scanner will not proxy the HTTP calls, right?

@7PH
Copy link
Author

7PH commented Dec 10, 2024

Hello and yes @kebetsi - do you have a suggestion to be clearer about it?

@kebetsi
Copy link

kebetsi commented Dec 11, 2024

@7PH I think it's fine. If I understood it correctly then it's clear.

@7PH 7PH force-pushed the doc/br/scannpm-61-no-proxy branch from ff9d2d3 to e89f7d9 Compare December 12, 2024 09:03
@7PH 7PH force-pushed the doc/br/scannpm-61-no-proxy branch from e89f7d9 to 281bbb4 Compare December 12, 2024 09:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@7PH 7PH enabled auto-merge (rebase) December 12, 2024 09:25
@7PH 7PH merged commit f6f823f into master Dec 12, 2024
4 of 6 checks passed
@7PH 7PH deleted the doc/br/scannpm-61-no-proxy branch December 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-paulger-sonarsource lucas-paulger-sonarsource lucas-paulger-sonarsource approved these changes

@kebetsi kebetsi kebetsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7PH @kebetsi @lucas-paulger-sonarsource