SCANNPM-49 Fix compatibility with other scanners (CLI, Scanner Engine) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7PH
force-pushed
the
bugfix/br/scannpm-49-npm-work-dir
branch
from
f705ee2 to
623f232
Compare
7PH
changed the title
lucas-paulger-sonarsource
approved these changes
Dec 2, 2024
7PH
force-pushed
the
bugfix/br/scannpm-49-npm-work-dir
branch
from
e042a0a to
7c35af2
Compare
…tial collision with userHome
7PH
force-pushed
the
bugfix/br/scannpm-49-npm-work-dir
branch
from
7c35af2 to
1ec2094
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
sonar.working.directory
Described by this ticket:
.scannerwork, same as the Scanner CLIarchive extraction path
The path for archive extraction was different than the one for the CLI Scanner. Therefore, when:
.sonarfolderThe analysis failed because the NPM Scanner is looking for the extracted content in
~/.sonar/cache/{sha}/{filename}_extractedwhere the CLI Scanner stored it in~/.sonar/cache/{sha}/{filename}_unzip. I've synchronized the value for both to_unzip.