Load all rules from QP at once #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
requested review from
mickael-caro-sonarsource and
costin-zaharia-sonarsource
|
There's ongoing AZP incident, the IT job failed on a cache task. |
mickael-caro-sonarsource
approved these changes
Mar 31, 2021
costin-zaharia-sonarsource
approved these changes
Apr 1, 2021
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
| } | ||
| if (r["templateKey"] != null) | ||
| var active = actives?.Value<JArray>(r["key"].ToString())?.FirstOrDefault(); | ||
| var rule = new SonarRule(r["repo"].ToString(), ParseRuleKey(r["key"].ToString()), r["internalKey"]?.ToString(), r["templateKey"]?.ToString(), active != null); |
There was a problem hiding this comment.
Would be great to extract the strings as constants.
There was a problem hiding this comment.
It's used just once.
There was a problem hiding this comment.
There are some which are used multiple times e.g. "key"
pavel-mikula-sonarsource
force-pushed
the
Pavel/RefactorRuleProcessing
branch
from
a0e743f to
53980d9
Compare
pavel-mikula-sonarsource
assigned pavel-mikula-sonarsource and unassigned costin-zaharia-sonarsource
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for #980
Old state:
New state: