Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCAN4NET-234 Use SONAR_SCANNER_OPTS to map the new properties #2314

Merged
merged 5 commits into from
Feb 10, 2025
Merged

SCAN4NET-234 Use SONAR_SCANNER_OPTS to map the new properties #2314

merged 5 commits into from
Feb 10, 2025

Conversation

sebastien-marichal
Copy link
Contributor

@sebastien-marichal sebastien-marichal commented Feb 4, 2025 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Use SONAR_SCANNER_OPTS to map the new properties SCAN4NET-234 Use SONAR_SCANNER_OPTS to map the new properties Feb 4, 2025
@sebastien-marichal sebastien-marichal marked this pull request as ready for review February 4, 2025 16:01
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about spaces in file path are handled correctly.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you make a note about the restrictions caused by the arguments escaping. We need to make this part of the documentation.

@sebastien-marichal
Copy link
Contributor Author

sebastien-marichal commented Feb 10, 2025 •
edited by jira bot
Loading

I have updated SCAN4NET-212 to include the escaping limitations in the documentation.

@sebastien-marichal sebastien-marichal merged commit 33ac59c into feature/MMF_4168 Feb 10, 2025
18 checks passed
@sebastien-marichal sebastien-marichal deleted the sma/props-map-2 branch February 10, 2025 09:23
sebastien-marichal added a commit that referenced this pull request Feb 14, 2025
@sebastien-marichal
SCAN4NET-234 Use SONAR_SCANNER_OPTS to map the new properties (#2314)
e5c7f5c
sebastien-marichal added a commit that referenced this pull request Feb 18, 2025
@sebastien-marichal
SCAN4NET-234 Use SONAR_SCANNER_OPTS to map the new properties (#2314)
b0d776d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastien-marichal @martin-strecker-sonarsource