-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental PR analysis: download cache #1376
Conversation
8363981
to
43153e0
Compare
2d55e93
to
9b83cf8
Compare
9b83cf8
to
ceaf4bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be simplified
src/SonarScanner.MSBuild.PreProcessor/Interfaces/IDownloader.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
599e43e
to
3389cf4
Compare
3389cf4
to
50d9310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I can actually read the UTs 😄
Tests/SonarScanner.MSBuild.PreProcessor.Test/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Fixes #1370
MMF: https://sonarsource.atlassian.net/browse/MMF-2875