-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental PR analysis: Implement the hashing #1372
Conversation
6d8075a
to
300544f
Compare
Tests/SonarScanner.MSBuild.PreProcessor.Test/PreProcessorTests.cs
Outdated
Show resolved
Hide resolved
// } | ||
} | ||
|
||
internal /* for testing */ string ContentHash(string path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use the async operations. Since here we target net46, we can use the FileStream
class (using var stream = File.Open(path, FileMode.Open);
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any other work to do meanwhile, so async will not help.
300544f
to
236994a
Compare
236994a
to
c3d4d6b
Compare
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1369
It works with this Java counterpart:
The biggest pain is
bytesToHex
part 🤦♂️ 🤦♂️ 🤦♂️