-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VsTestToolsInstallerInstalledToolLocation: Path to CodeCoverage.exe may contain net462 instead of net451 #1362
Conversation
Tests/SonarScanner.MSBuild.TFS.Test/Classic/BinaryToXmlCoverageReportConverterTests.cs
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.TFS.Test/Classic/BinaryToXmlCoverageReportConverterTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.TFS.Test/Classic/BinaryToXmlCoverageReportConverterTests.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.TFS.Classic/BinaryToXmlCoverageReportConverter.cs
Outdated
Show resolved
Hide resolved
src/SonarScanner.MSBuild.TFS.Classic/BinaryToXmlCoverageReportConverter.cs
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
|
||
<!-- | ||
Microsoft ResX Schema | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added all the whitespace back. I think it's better without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if you check 4597c1b?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was this way:
Before: Additional whitespace was there because the last edit was done using the VS UI for resx files.
- I changed the message by editing the resx with the VS XML editor -> the XML got formatted/cleaned up and the whitespace disappeared adf1ac8
- I changed the message again using the VS UI 4597c1b the whitespace was reintroduced by the UI
The final diff has the additional whitespace and therefore only shows the actual changes. We should keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please remove the whitespace though.
Can you merge it? I don't have permission due to the failing quality gate. |
I can't. Failed quality gate (low coverage). Only @pavel-mikula-sonarsource or @andrei-epure-sonarsource can. |
I'll merge it. Changed code is covered, uncovered parts are old debt that popped up due to cleanup (removing |
Fixes #1357