Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsTestToolsInstallerInstalledToolLocation: Path to CodeCoverage.exe may contain net462 instead of net451 #1362

Merged
merged 5 commits into from
Nov 24, 2022

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes #1357

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.9% 75.9% Coverage
0.0% 0.0% Duplication


<!--
Microsoft ResX Schema

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added all the whitespace back. I think it's better without it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the VS designer to edit the resx. And funny enough my Github diffview doesn't show the whitespace:

image

(I checked the hide Whitespace setting. It is off).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if you check 4597c1b?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was this way:
Before: Additional whitespace was there because the last edit was done using the VS UI for resx files.

  • I changed the message by editing the resx with the VS XML editor -> the XML got formatted/cleaned up and the whitespace disappeared adf1ac8
  • I changed the message again using the VS UI 4597c1b the whitespace was reintroduced by the UI

The final diff has the additional whitespace and therefore only shows the actual changes. We should keep it as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please remove the whitespace though.

@martin-strecker-sonarsource
Copy link
Contributor Author

Can you merge it? I don't have permission due to the failing quality gate.

@costin-zaharia-sonarsource
Copy link
Member

I can't. Failed quality gate (low coverage). Only @pavel-mikula-sonarsource or @andrei-epure-sonarsource can.

@pavel-mikula-sonarsource
Copy link
Contributor

I'll merge it. Changed code is covered, uncovered parts are old debt that popped up due to cleanup (removing this. smells)

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 5a64370 into master Nov 24, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Martin/CodeCoveragePath branch November 24, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VsTestToolsInstallerInstalledToolLocation: Path to CodeCoverage.exe may contain net462 instead of net451
3 participants