Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with .NET Core 2.1 and 3.1 #1061

Merged
merged 4 commits into from
Aug 27, 2021

Conversation

mickael-caro-sonarsource
Copy link
Contributor

@mickael-caro-sonarsource mickael-caro-sonarsource commented Aug 25, 2021

Compilation is done with .NET Core 3.1 to comply with LTS versions.

Artefacts names are all left as they are to not break anything (not a big deal).

We're going to switch to that flavor in the AzDo extension, that's why i put it in this release, feel free to tell me if this is not suitable, .NET Core 3.0 is still fine as long as we have the rollForward policy.

Fixes #1060

@mickael-caro-sonarsource mickael-caro-sonarsource changed the base branch from master to branch-5.3 August 25, 2021 13:02
@pavel-mikula-sonarsource pavel-mikula-sonarsource linked an issue Aug 26, 2021 that may be closed by this pull request
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Compile with .NET Core 3.1 Compile with .NET Core 2.1 and 3.1 Aug 26, 2021
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickael-caro-sonarsource mickael-caro-sonarsource merged commit 37f5a4e into branch-5.3 Aug 27, 2021
@mickael-caro-sonarsource mickael-caro-sonarsource deleted the mc/1060-compile-net-core-3.1 branch August 27, 2021 08:50
pavel-mikula-sonarsource added a commit that referenced this pull request Aug 31, 2021
* Compile with .NET Core 3.1

Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile with .NET Core 2.1 and 3.1
2 participants