mTLS with ClientCert Password #1014
Conversation
… a password. Fix to allow usage of one client cert for "begin" and "end" operations.
Sync with main fork
ghost
requested a review
from 
ghost
assigned 
|
@mickael-caro-sonarsource can we run the build for this one, please? |
|
@mickael-caro-sonarsource did you have time to take a look on this one? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hey @fabiostawinski sorry for the late reply. Busy on other things at the moment, so no release is planned. I'll still try to merge it into the next release branch. |
There was a problem hiding this comment.
Hi @fabiostawinski smalls fixes added in comments. Thanks !
Tests/SonarScanner.MSBuild.PreProcessor.Tests/WebClientDownloaderTest.cs
Outdated
Show resolved
Hide resolved
mickael-caro-sonarsource
force-pushed
the
branch-5.3
branch
from
dfcc2b7 to
9c9c78c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@fabiostawinski may i ask you to rebase on top of our master please ? Thank you. |
|
@mickael-caro-sonarsource still it is needed to rebase or all is ok? I merged the main fork with my fork. Is it ok? |
Get latest from master
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@fabiostawinski i don't think so, i still have the message on my side. You may only see a few commits in the list here after a proper rebase. |
|
@mickael-caro-sonarsource sorry for the basic question, but how you do the rebase? fabiostawinski:master should be rebased on sonarsource:master latest? |
|
@fabiostawinski i would say yes, and then rebase your PR branch on top of your 'new' master. |
… a password. Fix to allow usage of one client cert for "begin" and "end" operations.
|
@mickael-caro-sonarsource I rebased now, hope it works :) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed! |
|
@mickael-caro-sonarsource when the version 5.2.2 is planned to be released? |
|
@fabiostawinski sorry there was an issue with the GH release, it is now published. |
Today the current version is developed to allow ClientCert without password, for the "begin" operation it works good. But for the "end" operation, java required that the clientcert be with a password defined.
This is why in the current version we have to user two client certs, one (with no pw) for "begin" and another (with pw) for "end". This PR will allow to use only one clientcert with pw, for both operations and simplify the usage of mTLS.