Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLUGINAPI-34 add aliases for sonar.test.inclusions and sonar.test.exc… #67

Conversation

benjamin-campomenosi-sonarsource
Copy link
Contributor

No description provided.

@benjamin-campomenosi-sonarsource benjamin-campomenosi-sonarsource force-pushed the feature/bca/PLUGINAPI-34_add_aliases_for_sonar.test.inclusions_and_sonar.test.exclusions branch from a27e426 to fba9c80 Compare January 3, 2023 12:44
@benjamin-campomenosi-sonarsource benjamin-campomenosi-sonarsource force-pushed the feature/bca/PLUGINAPI-34_add_aliases_for_sonar.test.inclusions_and_sonar.test.exclusions branch from fba9c80 to 529fc54 Compare January 4, 2023 09:00
@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about really edge cases, what if users define both the legacy and alias properties with different values ? Will you use the legacy property in priority ? Do you plan to display a warning too, or an error ? I am not sure it should be documented in JavaDoc, as it's such an edge case. Up to you

I think the fact that it's an alias could be documented in the JavaDoc, to lower confusion for people seeing both and wondering what the difference is.

@benjamin-campomenosi-sonarsource
Copy link
Contributor Author

benjamin-campomenosi-sonarsource commented Jan 4, 2023

In Sonarqube, if we define both properties, we merge the value of both.. But a warning is log each time we use the alias..

If we look at the Why/What of SONAR-16491, I don't think we have to document the aliases, they are there to avoid the users to be too confused . Maybe we can discuss this edge case with the PM and the doc team?

@benjamin-campomenosi-sonarsource benjamin-campomenosi-sonarsource deleted the feature/bca/PLUGINAPI-34_add_aliases_for_sonar.test.inclusions_and_sonar.test.exclusions branch January 5, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants