Fix S1694 FP: Cconstructors and fields #9504
Conversation
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/Fix-S1694-FP-fields-and-methods
branch
2 times, most recently
from
130a17e to
eb8ec58
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/Fix-S1694-FP-fields-and-methods
branch
from
eb8ec58 to
2ae8d67
Compare
| { | ||
| "Id": "S1694", | ||
| "Message": "Convert this \u0027abstract\u0027 class to an interface.", | ||
| "Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/akka.net/src/core/Akka/Dispatch/Mailbox.cs#L554", |
There was a problem hiding this comment.
FP: the class has fields, it cannot be converted to an interface.
| { | ||
| "Id": "S1694", | ||
| "Message": "Convert this \u0027abstract\u0027 class to an interface.", | ||
| "Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/akka.net/src/core/Akka/Pattern/BackoffOptions.cs#L77", |
There was a problem hiding this comment.
FP: the class cannot be converted to an interface, because in .NET Standard 2.0 interfaces cannot have members with internal visibility.
| { | ||
| "Id": "S1694", | ||
| "Message": "Convert this \u0027abstract\u0027 class to an interface.", | ||
| "Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/akka.net/src/core/Akka.Remote/FailureDetector.cs#L17", |
There was a problem hiding this comment.
FP: the class cannot be converted to an interface, because in .NET Standard 2.0 interfaces cannot have readonly static fields.
zsolt-kolbay-sonarsource
requested review from
mary-georgiou-sonarsource and
Tim-Pohlmann
There was a problem hiding this comment.
Approved with the expectation that the behavior related to #9421 will be reverted, as discussed directly.
|
|
zsolt-kolbay-sonarsource
changed the title
zsolt-kolbay-sonarsource
removed the request for review
from mary-georgiou-sonarsource
zsolt-kolbay-sonarsource
deleted the
Zsolt/Fix-S1694-FP-fields-and-methods
branch
Fixes #9494